change assert.equal to assert.strictEqual #9946
Closed
aileenvl wants to merge 3 commits intonodejs:masterfrom
Closed
change assert.equal to assert.strictEqual #9946aileenvl wants to merge 3 commits intonodejs:masterfrom
aileenvl wants to merge 3 commits intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
mscdex
added
cluster
Contributor
|
Please follow the commit message guidelines here. |
aileenvl
changed the title
aileenvl
changed the title
aileenvl
changed the title
added 2 commits
December 1, 2016 11:09
this commit makes a change on test file from an asset.equal() to assert.strictEqual()
….com/aileenvl/node into typo-test-cluster-send-handle_Aileen change commit message to follow guidelines
jasnell
approved these changes
Dec 5, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
The commits will need to be squashed but LGTM
addaleax
approved these changes
Dec 8, 2016
Member
|
Landed in 558fa1c, thanks for the contribution! |
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
PR-URL: #9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
PR-URL: #9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
make a change from assert.equal() to asser.strictEqual()